Noobie: Proublem with nested While Do loops

[ifandbut]

EDIT: Fond a different/better way of doing the same thing. See my post in the scripts section for the finished script.


Hi everyone. I just started scripting in general but I'v had a decent ammount of programing experience in everything from Basic to C so I kinda know what I am doing.
I wanted to make my own Summon Magic skill bot (yes I know it's been done before but I wanted something to do) and I was able to creat the summon and release part just fine but when I get to the resting to get MP back I ran into a proublem. I'll post my code now.
summon1 = "/ma Carbuncle <me>"
summon2 = "/ma Leviathan <me>"
summon3 = "/ma Ramuh <me>"
release = "/pet Release <me>"
heal = "/heal"
current_mp = FFXI.player_GetCurrentMP()
max_mp = FFXI.player_GetMaxMP()

while true do

while current_mp > 7 do --Summons 3 avatars
Control.control_SendString(summon1)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()

Windower.script_Sleep(1000)

Control.control_SendString(summon2)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()

Windower.script_Sleep(1000)

Control.control_SendString(summon3)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()

Windower.script_Sleep(4000)

end
--PROUBLEM START
Control.control_SendString(heal)

while current_mp > max_mp do --Should rest till full MP
Windower.script_Sleep(5000)
current_mp = FFXI.player_GetCurrentMP()
end

Control.control_SendString(heal)

end

Ok, so I summon avatars till I cant summon any more (there maybe better ways of doing this but I'll fix that latter) then I should input the command /heal to FFXI and heal. The script then checks my current MP and sees if it's equal to my max MP every 5 seconds, if it is then I input the command /heal to FFXI to make my character stand up again and continue to summon.

Proublem is when I come to my mp check loop all my character does is kneel then stand up again. Is there a proublem where I put my calls to the /heal or a proublem with my mp checking loop?

Thanks for any help,
Ifandbut

[sdphantom]

while current_mp > max_mp do
Basic logic error.
It'll work better if you flip the sign to 'less than' instead of 'greater than'.

Don't worry too much, even I make that mistake once in a while.

[Onitaru]

I try'd that and oddly it didn't work (sorry I just found it odd he didn't post back) and I plan to try something like this for my healing magic)

[petar113507]

You may want to tinker with the settings of this little body, you already said this is where the problems start... I was thinking more in the range of storing the range of the MP's into variables.

I dont know, I think SD phantom nailed this pretty well, but I think your while statement is wrong.

I would go within the area of


(Set MaxMP into a variable, and get another variable to be  OneLess = MaxMp - 1 )

while CurrentMP < OneLess
Control.control_SendString(heal)
Windower.script_Sleep(5000)
(Check your Current MP) current_mp = FFXI.player_GetCurrentMP()



Just off the top of my head, but this sounds right, because when you get to your full MP bar, then you break the while Statement, which I think is where your script had a little trouble with before. ;D

[Onitaru]

on my last post it did heal not sure why it didn't the first time but I'll go read up on what petar was saying.

[Jubei]

Changing the script to look something like this will probably do it. Using status is very handy when creating heal scripts. This possibly won't work because i didn't test it, but it's on the right lines, i think


summon1 = "/ma Carbuncle <me>"
summon2 = "/ma Leviathan <me>"
summon3 = "/ma Ramuh <me>"
release = "/pet Release <me>"
heal = "/heal"
current_mp = FFXI.player_GetCurrentMP()
max_mp = FFXI.player_GetMaxMP()
status = FFXI.player_GetStatus()

while true do

if current_mp > 7 and status ~= 33 then --Summons 3 avatars
Control.control_SendString(summon1)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()
status = FFXI.player_GetStatus()---checks status again

Windower.script_Sleep(1000)

Control.control_SendString(summon2)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()
status = FFXI.player_GetStatus()---checks status again

Windower.script_Sleep(1000)

Control.control_SendString(summon3)
Windower.script_Sleep(9000)
Control.control_SendString(release)
current_mp = FFXI.player_GetCurrentMP()
status = FFXI.player_GetStatus()---checks status again

Windower.script_Sleep(4000)

end

--PROUBLEM START

if current_mp <= 7 and status ~= 33 then
Control.control_SendString(heal)
Windower.script_Sleep(1000)
end

while current_mp ~= max_mp and status = 33 do --Should rest till full MP
Windower.script_Sleep(5000)
status = FFXI.player_GetStatus()
current_mp = FFXI.player_GetCurrentMP()
end

if current_mp = max_mp and status = 33 then
Control.control_SendString(heal)
Windower.script_Sleep(1000)
end



end


[petar113507]

OOPSIE! I checked my last post, and I fiddled with a healing script myself, and the Oneless thing works, but you have to put the Sendstring before the while statement, otherwise it;s rather ineffective. It gets up every five seconds, and that's no good.

this is actually what I got to work. It's pretty sweet.

this is just the resting part of the script. ^_^ Like I said, it's spiffy stuff here.


Control.control_SendString(heal)  -- here you rest

while CurrentMP < OneLess
Windower.script_Sleep(1000)
end

--and you continue to rest until the loop is broken, then you sendstring of Heal again

Control.control_SendString(heal)



[sdphantom]

New code posted in
Lunar Scripts » Summon Skill Bot

[petar113507]

si si~ I saw, just had to correct meself, for a concious reason.

[ifandbut]

Sorry I did not repply sooner. Been sick.
First off /slap <me> for makeing that stupid greater-than/less-than error.

Right now I dont really know what would be the best/most lag free, if statments or while loops.

I keep forgetting that the status checking exist in Lunar. I'll intergrate some of that into my next version.

[sdphantom]

ifandbut said:

Right now I dont really know what would be the best/most lag free, if statments or while loops.

'If and 'While' statements have their own places.

You loop with 'While' if you're repeating code, but I also use it to isolate what sections are being executed at any one time. Basically a way of saying, "I don't want any more code run while or until something happens."

'If' statements are just used to tell the code to branch off depending on different conditions.



I write code the way I do so I can follow it easier. I work in more of a linear approach rather than just stuffing code in random spots.