IT TABS!... now what?

[Dalendam]

well ive been stedy workin on my bot for 3 days or so (remember i have school) all that, i had it workin back when i thought i had to use ffxihelper but that lagged so bad i couldnt provoke faster then a noob, now i have the thing tabbing just right, but wont provoke any more, i pmed tiny he helped me alot told me that i no longer needed ffxihelper which crushed the lag problem but now i cant figure out how to make this stupid thing provoke. if any ones willing to help me out let me know here is the broken script

FFACTInit();
$fight = 0

Do
Send("{TAB}")
Until $fight = 1
Sleep(10)
FFACTTargetUpdate();
$mob = FFACTTargetGetName()
If $mob = " Carrion Worm" Then
Send("^1");
$fight = 1
Fight()
EndIf


Func Fight()
Sleep(3000)
Send("^2");macro for auto attack
Sleep(100)
Send("{Up}")
EndFunc

every thing seems so simple, yet i cant get the answers for anything i need, i would really like to learn botting/scripting, i need an example that actually works and is proven to work to actually start my learning. thanks for all the help guys#nosmileys

[Dalendam]

well 3 days later and ive masterd the art of tab botting, still no provoke though. i just seriously dont understand why this crap doesnt work w.e i hope some one helps if they have a chance

[TinyTerror]

Try this. I havent tested it, but the general idea is there. I added a whole bunch of comments for readability.

FFACTInit(); //Start up ffact interface
$MyTarget=" Carrion Worm"; //Set target name here

While 1=1; //Start infinite main loop

;//This loop sleeps until numlock is on.
;//This effectively pauses the script if numlock is off.
;//Even if numlock is on, the script will still sleep for 10ms per cycle. 

Do
Sleep(10);
Until NumCheck()=1; //Do this until num lock is on

Send("{TAB}"); //Aquire target
FFACTTargetUpdate(); //Check target
$mob = FFACTTargetGetName(); //Get mob name

;//Voke condition
If $mob = $MyTarget Then; //Check to see if this is the right target.
Send("^1");
Fight();
EndIf

;//This loop sleeps until the target is killed or untargetted
While $mob=$MyTarget; //Do this until target lost
FFACTTargetUpdate(); //Check target
$mob = FFACTTargetGetName(); //Get mob name
Sleep(2000);
WEnd

WEnd; //End infinite main loop

Func Fight()
Sleep(3000)
Send("^2");macro for auto attack
Sleep(100)
Send("{Up}")
EndFunc

[Dalendam]

thanks tiny, ill go check it out right now, then use it to try and fix mine on my own

[TinyTerror]

Ok, good luck!

[playaplaya]

Okay, so I'm not as smart as most here, but I do know one thing. Your using the GetTargetName command... and you said you eliminated the helper.au3 file... theres your voke problem. it tabs because thats a stand alone script. your other function is a call.. to the helper file. what i did was slim the helper and got rid of all the extra bs like tnl and chat logging and crap. runs mighty fine. hope this helps.

Playaplaya

[TinyTerror]

Lol, I got rid of the FFACT_Helper.au3 because autoterror now supports target info calls natively without the need for a helper script. Good work spotting that though

[Paranoia]

I still can't get AutoTerror to Connect with FFACT correctly. It says the connection is initialized, but, nada. Tabs ok, but won't voke.

[Duke Newrise]

I'm even having problems getting target info with AutoTerror. You tested this before you released it, right Tiny?

[Paranoia]

I figured one thing out.

I tested it on two different things. Single-word mobs, and double-worded mobs. It has no problem with the singles, but doesn't work well with doubles. Clipper, i've had no trouble with. Also, I don't need a space before the name for it to work with clippers.

[TinyTerror]

Interesting. Yeah I tested it for several hours before release. Its sorta hard to find all this stuff

If anyone knows C++, the source is open. I can provide the project files for MS Dev 7 if anyone wants to compile. I would be more than happy to accept community modifications of autoterror.

I'll check out the spacing issues in the target info code. I think its most likely sscanf using spaces as a delimiting symbol in FFACT_Interface::UpdateTarget() in FFACT_Interface.cpp. I'll try to fix it tomorrow.

Bonus points for Paranoia for finding this one, and irritation for me for not finding this earlier >_<

[TinyTerror]

In the mean time, has anyone tried identifying mobs by the first word in thier name? Does it work?

[Paranoia]

Yep, works.

[TinyTerror]

I confirmed the place where this error happens. The fix isnt too bad. I'll fix it tomorrow night after work and make a release at 10 or 11 PM est barring complete disaster.

Sscaf has spaces hardcoded as delimiting characters. This means if you target a mob or player with a multiword name, the first word or an empty string gets assigned to the name. I will write a custom parser similar to FFACT_Helper's intermediate results parser that should fix the problem pretty quickly.

Sorry about the giant bug! I'll work harder to make sure this doesnt happen next time!

[TinyTerror]

Thanks alot Paranoia.