Fishbot -- Can you Help me make it?

[petar113507]

Okiedokie... This is to fight the fish, and breaks itself after I get down to Pixel10

Because I labeled individual pixels, I realise that's what made it kinda ineffecinet. I know there's a better way. I just don't know how to get there. On other forums I have been flamed for posting scripts that work, but they are a tad on the basic side, but they get the task done. I have left those forums....

So far this has been a kickass place.
I broke the loop, because I don't have a text reader, nor do I know how to make one. I set this to a macros, and I still have alot of whitespace in here.

(Please don't quote this... I'm pretty sure that streches posts.)
here goes: ;D




$Pixel64=PixelGetColor( 772 , 567 )
$Pixel63=PixelGetColor( 771 , 567 )
$Pixel62=PixelGetColor( 770 , 567 )
$Pixel61=PixelGetColor( 769 , 567 )
$Pixel60=PixelGetColor( 768 , 567 )
$Pixel59=PixelGetColor( 767 , 567 )
$Pixel58=PixelGetColor( 766 , 567 )
$Pixel57=PixelGetColor( 765 , 567 )
$Pixel56=PixelGetColor( 764 , 567 )
$Pixel55=PixelGetColor( 763 , 567 )
$Pixel54=PixelGetColor( 762 , 567 )
$Pixel53=PixelGetColor( 761 , 567 )
$Pixel52=PixelGetColor( 760 , 567 )
$Pixel51=PixelGetColor( 759 , 567 )
$Pixel50=PixelGetColor( 758 , 567 )
$Pixel49=PixelGetColor( 757 , 567 )
$Pixel48=PixelGetColor( 756 , 567 )
$Pixel47=PixelGetColor( 755 , 567 )
$Pixel46=PixelGetColor( 754 , 567 )
$Pixel45=PixelGetColor( 753 , 567 )
$Pixel44=PixelGetColor( 752 , 567 )
$Pixel43=PixelGetColor( 751 , 567 )
$Pixel42=PixelGetColor( 750 , 567 )
$Pixel41=PixelGetColor( 749 , 567 )
$Pixel40=PixelGetColor( 748 , 567 )
$Pixel39=PixelGetColor( 747 , 567 )
$Pixel38=PixelGetColor( 746 , 567 )
$Pixel37=PixelGetColor( 745 , 567 )
$Pixel36=PixelGetColor( 744 , 567 )
$Pixel35=PixelGetColor( 743 , 567 )
$Pixel34=PixelGetColor( 742 , 567 )
$Pixel33=PixelGetColor( 741 , 567 )
$Pixel32=PixelGetColor( 740 , 567 )
$Pixel31=PixelGetColor( 739 , 567 )
$Pixel30=PixelGetColor( 738 , 567 )
$Pixel29=PixelGetColor( 737 , 567 )
$Pixel28=PixelGetColor( 736 , 567 )
$Pixel27=PixelGetColor( 735 , 567 )
$Pixel26=PixelGetColor( 734 , 567 )
$Pixel25=PixelGetColor( 733 , 567 )
$Pixel24=PixelGetColor( 732 , 567 )
$Pixel23=PixelGetColor( 731 , 567 )
$Pixel22=PixelGetColor( 730 , 567 )
$Pixel21=PixelGetColor( 729 , 567 )
$Pixel20=PixelGetColor( 728 , 567 )
$Pixel19=PixelGetColor( 727 , 567 )
$Pixel18=PixelGetColor( 726 , 567 )
$Pixel17=PixelGetColor( 725 , 567 )
$Pixel16=PixelGetColor( 724 , 567 )
$Pixel15=PixelGetColor( 723 , 567 )
$Pixel14=PixelGetColor( 722 , 567 )
$Pixel13=PixelGetColor( 721 , 567 )
$Pixel12=PixelGetColor( 720 , 567 )
$Pixel11=PixelGetColor( 719 , 567 )
$Pixel10=PixelGetColor( 718 , 567 )
$Pixel9=PixelGetColor( 717 , 567 )
$Pixel8=PixelGetColor( 716 , 567 )
$Pixel7=PixelGetColor( 715 , 567 )
$Pixel6=PixelGetColor( 714 , 567 )
$Pixel5=PixelGetColor( 713 , 567 )
$Pixel4=PixelGetColor( 712 , 567 )
$Pixel3=PixelGetColor( 711 , 567 )
$Pixel2=PixelGetColor( 710 , 567 )
$Pixel1=PixelGetColor( 709 , 567 )
$Pixel0=PixelGetColor( 708 , 567 )

Func FishFight6()
Send( "{NUMPAD6}" )
Send( "{NUMPAD6}" )
Send( "{NUMPAD6}" )
Send( "{NUMPAD6}" )
Send( "{NUMPAD6}" )
Send( "{NUMPAD6}" )
EndFunc
If( $Pixel64 = 10198015 ) Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel64 = 10198015 )
ThenFishFight6()
EndIf
If( $Pixel63 = 10198015 ) Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel63 = 10198015 ) Then
FishFight6()
EndIf
If( $Pixel62 = 10198015 ) Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel62 = 10198015 ) Then
FishFight6()
EndIf
If( $Pixel61 = 10198015 ) Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel61 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel60 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel60 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel59 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel59 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel58 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel58 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel57 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel57 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel56 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel56 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel55 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel55 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel54 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel54 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel53 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel53 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel52 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel52 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel51 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel51 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel50 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel50 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel49 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel49 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel48 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel48 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel47 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel47 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel46 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel46 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel45 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel45 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel44 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel44 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel43 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel43 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel42 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel42 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel41 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel41 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel40 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel40 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel39 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel39 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel38 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel38 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel37 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel37 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel36 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel36 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel35 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel35 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel34 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel34 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel33 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel33 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel32 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel32 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel31 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel31 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel30 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel30 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel29 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel29 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel28 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel28 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel27 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel27 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel26 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel26 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel25 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel25 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel24 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel24 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel22 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel22 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel22 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel22 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel21 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel21 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel20 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel20 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel19 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel19 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel18 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel18 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel17 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel17 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel16 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel16 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel15 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel15 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel14 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel14 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel13 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel13 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel12 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel12 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel11 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel11 = 10198015 )Then
FishFight6()
EndIf
If( $Pixel10 = 10198015 )Then
Send( "{NUMPAD4}" )
EndIf
If( $Pixel10 = 10198015 )Then
FishFight6()
EndIf


[petar113507]

Ok. Gotta Study for AP, and drama class.
Tests....

I see new ways now to construct scripts. I'll look at more advanced scripts to get an Idea of what to do.

Lemme know how I can modify this script, and How I could improve on new ones! Anything is appreciated.

:Because A beginner can never learn too much of the basics:

-- Peter Romo

[TinyTerror]

Ok, thats not going to work, because you are comparing specific pixel values. You need to use redlevels for it to work. Also, you aren't looping your stamina detection code. This script will execute in about 0.5 seconds and then terminate. Also, look into using an array to store all of your stamina pxel values. It will keep you from having to have 70+ variables. A loop can als be used to consolidate yur if statements also. I'll code something up tomorrow that should work.

Good first try though. You've got balls for actually trying fishing as your very first script

[petar113507]

admin said:

Ok, thats not going to work, because you are comparing specific pixel values. You need to use redlevels for it to work. Also, you aren't looping your stamina detection code. This script will execute in about 0.5 seconds and then terminate. Also, look into using an array to store all of your stamina pxel values. It will keep you from having to have 70+ variables. A loop can als be used to consolidate yur if statements also. I'll code something up tomorrow that should work.

Good first try though. You've got balls for actually trying fishing as your very first script

Thanks tiny! (I took out the loop just for the sake of cutting down length for the script. >< Still probally wouldnt have worked as well as I thought.)

It works in, One section of port bastok. which is where I never moved from that spot for three days. I have to trip the out of game macros a few times, but it kills the fish for me, sorta anyway. ^_^

Oh, I understand arrays and iterators, vectors as well from C++, which means it sorta should be similar, but that was before C++ got outdated, and plus cause it's object oriented....

Well I don't know how to store values in arrays in AutoIT. Any functions?

[TinyTerror]

Oh, so you did take out a loop? That would explain why I thought it wouldn't work. But hey, if it works, great job. Here is one that I wrote this morning. I haven't tested it and don't really intend to, but the general idea is there. It's probably full of errors, as I haven't messed with autoit in a long time. I tried to comment as much as possible to make it understandable. As you can see I use arrays, functions, and loops to do alot of the work that you do in those big blocks of pixel get color and if statements. If you have any questions, post away.



Global $BarWidth=64; //assumes the stamina bar is 64 pixels long.
Global $BarX=708; //Sets the x coordinate of the bar.
Global $BarY=567; //sets the y coordinate of the bar.
Global $RedThreshold=128; //Sets the level of red needed to be counted as stamina.


;//GetRedLevels gets all of the red levels of the pixels in the stamina bar, and returns the
;//results as an array with $BarWidth elements.

Func GetRedLevels()
Dim &RedLevels[$BarWidth]; //Make array with $BarWidth elements.
For $x=0 to $BarWidth Step 1; //Run the following $BarWidth times.
$PixelColor=GetPixelColor($x+$BarX,$BarY); //Get pixel color for ($x+$BarX,$BarY)
$PixelHex=Hex($MyPixel,StringLen($MyPixel)); //Get hex value of pixel
$RedHex=StringLeft($PixelHex,2); //Get the red characters from $PixelHex
$RedLevels[$x]=Dec($RedHex); //Puts the redlevel into $RedLevels[$x]
Next; //End the loop
Return $RedLevels; //Return the $RedLevels array
EndFunc //End of function


;//GetStaminaPercent takes an array $RedLevels (assumed to have $BarWidth elements) and counts
;//The number of pixels in the array starting from element 0 that are greater than $RedThreshold.
;//When it finds a pixel that is less than $RedThreshold, $Stamina/$BarWidth is returned. This
;//value should be the percent of stamina the fish has left.

Func GetStaminaPercent($RedLevels)
$Stamina=0; //Set $Stamina to 0
For $x=0 to $BarWidth Step 1; //Run the following $BarWidth times
If $RedLevels[$x]>$RedThreshold Then; //Checks if pixel is > than $Redthreshold.
$Stamina=$Stamina+1; //If so, add one to $Stamina
Else; //Otherwise
Return $Stamina/$BarWidth; //Return Stamina percent
Endif; //End the if statement
Next; //End the loop
Return 100; //Return full stamina
EndFunc; //End of function


;//ToggleDirection changes $CurrentDirection to the opposite direction. It takes $CurrentDirection
;//as an argument and returns the new direction.

Func ToggleDirection($CurrentDirection)
If $CurrentDirection="{NUMPAD4}" Then //If $CurrentDirection is "{NUMPAD4}"
$CurrentDirection="{NUMPAD6}"; //Change it to "{NUMPAD6}"
Else; //Otherwise
$CurrentDirection="{NUMPAD4}"; //Change it to "{NUMPAD4}"
EndIf //End if statement
Return $CurrentDirection; //Return modified direction
EndFunc; //End of function


;//Main function

$OldStamina=100; //Old stamina variable set to 100
$StaminaPercent=100; //Stamina variable set to 100
$CurrentDirection="{NUMPAD4}" //Sets starting direction to "{NUMPAD4}"
$Interval=1000; //Sets loop timer to 1000 ms
AutoItSetOption ("SendKeyDownDelay",$Interval); //Keys will be pressed for $Interval ms
Do //Start loop
$StaminaPercent=GetStaminaPercent(GetRedLevels()); //GetStamina percent
If $StaminaPercent>=$OldStamina Then; //Check if Stamina has decreased
$CurrentDirection=ToggleDirection(); //If not, change direction
EndIf; //End if statement

$OldStamina=$StaminaPercent; //Set $OldStamina to $StaminaPercent
Send($CurrentDirection); //Send the current direction
Sleep($Interval); //Pause script for $interval ms
Until $StaminaPercent<=0 //Do this until fish escapes or dies.


[petar113507]

Hey tiny, If you did make bots for gilsellers.... that would dominate the economies...>.> Glad you're on our side. thanks for the functions.

[TinyTerror]

Gil sellers can suck my left nut.

[petar113507]

Well said. I'm going to study the script, make notes on it... mmkay?

[petar113507]

Hey tiny, Is it allright If I post the stuff I didn't understand in that script? I wouldn't ask for an explination, cause that would take twice as long as a refrence.

Could you once more put me in the right direction?

[TinyTerror]

Yeah go ahead and post whatever you want. I'll explain it.

[petar113507]

Thanks Again Tiny!!

Global (I already know how this declares, but I don't get it how it really sets the bar to a public level. Is the bar a range of pixels?)
Dim (Never heard of it.)
I don't know if you declared $MyPixel before you used it.
Step 1 (I doon't know how this is used.)

(I like your idea of Toggle Direction. I'll use that in The next fishbot if that's allright by you., if that's allright by )

And I understand what GetRedLevels() Does, just I don't know How it does it. Could You explain how it works?

Func GetRedLevels()
Dim &RedLevels[$BarWidth]; //Make array with $BarWidth elements.
For $x=0 to $BarWidth Step 1; //Run the following $BarWidth times.
$PixelColor=GetPixelColor($x+$BarX,$BarY); //Get pixel color for ($x+$BarX,$BarY)
$PixelHex=Hex($MyPixel,StringLen($MyPixel)); //Get hex value of pixel
$RedHex=StringLeft($PixelHex,2); //Get the red characters from $PixelHex
$RedLevels[$x]=Dec($RedHex); //Puts the redlevel into $RedLevels[$x]
Next; //End the loop
Return $RedLevels; //Return the $RedLevels array
EndFunc ;  //End of function

that's just about what I didn't understand. Could you elaborate on the String, and the hex? different one is I didn't understand how you used Barwidth and X. (For $x=0 to $BarWidth Step 1)

[TinyTerror]

Ooops, $MyPixel should be $PixelColor. I copied and pasted the redlevel code from a previous post and forgot to change the variable names.

Dim is used to make a variable an array. It is short for dimension. For example:
Dim $Array[10] makes an array with 10 elements.
Dim $Array[10][20] makes a 2 dimensional array or 10 by 20 elements.

When I used Global on $BarWidth, it was not really needed. Any variable declared outside of a function is assumed to have a global scope.

$BarWidth is just a variable that holds the length of the stamina bar in pixels. In this case I set it to 64 pixels. If you look in some of my loops, I count from 0 to $Barwidth. When I do this, I am usually doing an operation (getting the redlevel in this case) for each pixel in the stamina bar.

And yes, you can use any concept or code I post to the forum. Just don't tell people its yours

GetRedLevels is the most complex function in the script, but what it does is fairly simple. The first thing you see in the function is the for loop that drives it. This for loop counts from 0 to the number stored in $BarWidth (54 in this case), so whatever is within the loop gets executed $BarWidth number of times. The Step 1 in the for loop means that the loop adds 1 to $x each time it cycles. As the for loop counts up, $x goes from 0 to $Barwidth. Immediately following the for loop is the getpixelcolor statement. It gets the color of one pixel at a time for each cycle of the loop, starting at ($BarX,$BarY) and ending at ($BarX+$x,$BarY). Each pixel is stored in the variable $PixelColor, and then converted into a hex string which is then stored in $PixelHex in the next line. $PixelHex now contains the string hex representation of the pixel color. To get the red level, we want the first two characters of this string. StringLeft gets the two leftmost characters and stores them as a string in $RedHex. Next, $RedHex is converted back into decimal by the Dec function, and stored in element $x of $RedLevels (remember that $RedLevels has $BarWidth elements, one for each pixel in the stamina bar). At the end of this function, after the loop has executed $BarWidth times, $RedLevels will contain $BarWidth numbers that represent the red leve in each pixel of the stamina bar.

[petar113507]

Okiedokie. Tonight I'll post the script I made in HON english. Last period right now. I'll use something like your toggle direction, I think I can post what I understand with the toggledirection. So it'll be your idea, but I think I'll program it in my own way.

For sure, I'll need you or DarkAuqas to help with the redlevel in this bot. I'm shooting for under 200 lines, tops.

[petar113507]

Tiny, I wrote most the script. It works great for what that's worth. I used your Redlevel function (Darkaquas's redlevel script helped me understand that.)

I'm using most your script. I fuigure I'll just make your script work, not revamp it all so it works a little-less smoothly.

== Good programmers are not lazy. They just don't mess with that what would take them a very long time, and what is near perfection. That's not being lazy, that's working smarter.

[TinyTerror]

It's cool you got it working. If you don't mind, would you post the script to this thread?