I'm tryin...

[dragondude]

Well I'm tryin to make my first script... It's just a stupid enhancing magic thing but I can't get it to work... I tried to follow the same scripting method as the summoning one made by ifandbut but it is just not turning out... can you help me improve it? here it is:


-------Enhancing Magic Skill Up Bot v1.0
-------By: Dragondude XIV
-------Script basis by: Kevin Schneider (aka Ifandbut)

Windower.console_write("Enhancing Magic Skill up Bot")
Windower.console_write("By:Dragondude XIV")
Windower.console_write("[e-mail]")
Windower.console_write("Enjoy!!")


while true do
current_mp = FFXI.player_GetCurrentMP()
max_mp = FFXI.player_GetMaxMP()
status = FFXI.player_GetStatus()

if current_mp < 9 then --If I dont have enough MP then rest
if status ~= 33 then
Control.control_SendString("/heal on")
end
end

if current_mp == max_mp then --When I have full mp stop resting
Control.control_SendString("/heal off")
end

current_mp = FFXI.player_GetCurrentMP()

----Start of chain Enhancing magic block----
if current_mp >= 9 and statu ~= 33 then
Control.control_SendString("/ma Protect <me>")
end

current_mp = FFXI.player_GetCurrentMP()

if current_mp >= 20 then
Control.control_SendString("/ma Protect II <me>")
Windower.script_Sleep(3000)
end

current_mp = FFXI.player_GetCurrentMP()

if current_mp >= 17 then
Control.control_SendString("/ma Blink <me>")
Windower.script_Sleep(6000)
end

Windower.script_Sleep(4000) --make sure all the casting timers are reset and account for lag
end  

Its my first one, tell me what you think and what i did wrong and how to improve, lol.

[TinyTerror]

You need to tell us what the problem is before asking for us to fix it

[dragondude]

ok, it is saying "script unloded" and not doing anything when i try and load it into FFXI, then i took out a couple quotation marks that i realized shouldnt be there and it crashed FFXI... there.

[dragondude]

Ok, ifandbut's script was the closest one to the one i wanted to make, but when, thats what i came up with, now i can't get it to load to FFXI... I've done almost everything the same (sorry if, its my first time but i credited you!) So, someone anyone, please tell me what i did wrong! ty.

[sdphantom]

If you scroll down from that SMN bot code that is posted by Ifandbut, you can find my modified code that can easily be reconfigured to work with this kind of skillups. Just set the cast and recast times along with the spell to cast and the casting cost. Also set the perpetuation cost to 0 (normal spells have no perpetuation). The script has built in code for healing. The only thing is that it will send the release command after casting and it will wait a minimum of 10 secs before recasting. Other than those issues, the script I wrote and posted below Ifandbut's would work fine.

Btw, check out line 29..
if current_mp >= 9 and statu ~= 33 then
I think you forgot the 's' on your status varible.

[dragondude]

Thanx, I really have no clue what the status thing is, just put it there cuz ifandbut had it there lol

So thanks.

[StarHawk]

dragondude said:

Thanx, I really have no clue what the status thing is, just put it there cuz ifandbut had it there lol

So thanks.

Umm....

A BIG suggestion would be to not do things just because you saw someone else do them, but actually understand what you are doing.

If you have no idea what status does, how can you know that what it does is even what you want it to do?

[dragondude]

I dont =/ i'm just trying to figure out what these things do though.

[sdphantom]

dragondude said:

Thanx, I really have no clue what the status thing is, just put it there cuz ifandbut had it there lol

So thanks.

np ^^

Anyway, that section of code is to manage automatically healing MP back when it gets too low to cast any of the spells. FFXI.player_GetStatus() gives the state that the player is in (standing, sitting, healing, fishing, etc.)

[dragondude]

Ahhh, i see, so 33 would be?? standing??

[sdphantom]

dragondude said:

Ahhh, i see, so 33 would be?? standing??

0 is standing
33 is healing

[dragondude]

O cool, thank you.